Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating grayscale pdf #590

Closed
vyankatesh24 opened this issue Mar 4, 2019 · 19 comments · Fixed by #681
Closed

Error when creating grayscale pdf #590

vyankatesh24 opened this issue Mar 4, 2019 · 19 comments · Fixed by #681

Comments

@vyankatesh24
Copy link
Contributor

vyankatesh24 commented Mar 4, 2019

Describe your issue here.

Error occures "Error on creating application folder".

Steps to reproduce

  • Create PDF
  • Select Images
  • Create grayscale PDF.
  • Enter Name and Press OK

Expected behaviour

  • PDF should be created correctly
  • Images shouldn't become grayscale when Cancel is pressed.

Actual behaviour

  • Error occures "Error on creating application folder".
  • Shows images count as it is but when we click on any enhancement option Snackbar shows "No images Selected".
  • Create PDF remains Enabled.
@itnug987
Copy link

itnug987 commented Mar 4, 2019

I want to work on this issue

@Swati4star
Copy link
Owner

Sure @itnug987

@sidhuparas
Copy link

@itnug987 How's the progress? Any updates?

@itnug987
Copy link

itnug987 commented Mar 9, 2019

Installed the project in my local machine. Found out where the error is occurring. Trying to fix it.

@sidhuparas
Copy link

@itnug987 Updates?

@itnug987
Copy link

I am trying to fix it. But when I try to edit any file "Checkstyle rule violations were found" error is occurring.

@dr0pdb
Copy link

dr0pdb commented Mar 16, 2019

@itnug987 It is not a fatal error. It might be because you're not following the conventions of the project. for eg. maybe you're not using variable names according to project convention or maybe using 2 space indentation etc.

I would be able to help more if you show me the error log and screenshot.

@sidhuparas
Copy link

@itnug987 It's exactly what @srv-twry said. Just refer to the file checkstyle.html whose path is included in the error message. That will help you solve the error(s).

@itnug987
Copy link

Thank you so much @sidhuparas @srv-twry for the guidance. I am able to follow the conventions of the project now. Regarding the update of the issue: Error is occurring because the new file is not created in saveCurrentImageInGrayscale() in imagetopdfFragment.java file. Here dir.mkdirs() is returning false. I am not understanding what should be the pathname to be given. I will try to fix it.
Screenshot (32)

@sidhuparas
Copy link

Try something like this for debugging purposes:
File file = new File( Environment.getExternalStorageDirectory(), "/Folder");

@itnug987
Copy link

Tried it. Not working.

@sidhuparas
Copy link

Make sure you have granted read and write permissions for external storage.

@itnug987
Copy link

Yes, I have granted read and write permissions for external storage also.

@vyankatesh24
Copy link
Contributor Author

@itnug987 Any Progress?

@itnug987
Copy link

@vyankatesh24 I am able to create the pdf but not in grayscale. I am working on it.

@vyankatesh24
Copy link
Contributor Author

@vyankatesh24 I am able to create the pdf but not in grayscale. I am working on it.

The PDF is already getting created in grayscale, but when the cancel is clicked.

Any Progess Now?

@itnug987
Copy link

I am not working on this issue. Please make this issue open to everyone @vyankatesh24.

@Ni3verma
Copy link
Contributor

Ni3verma commented Apr 3, 2019

@vyankatesh24
assign it to me

@vyankatesh24
Copy link
Contributor Author

Sure @Ni3verma 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants