grayscale filter fix

[Ni3verma]

Description

grayscale image is getting created, no error if we press cancel and other enhancement options are also working fine

Fixes #590

Type of change

Just put an x in the [] which are valid.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• ./gradlew assembleDebug assembleRelease
• ./gradlew checkstyle

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codeclimate]

Code Climate has analyzed commit 6bb3ce4 and detected 0 issues on this pull request.

View more on Code Climate.

[vyankatesh24]

@Ni3verma
Still, I am getting error Error on creating application folder while creating grayscale PDF

[Ni3verma]

I am not getting any error. Please tell me steps to reproduce the error

[vyankatesh24]

I am not getting any error. Please tell me steps to reproduce the error

Same as in issue #590

[Ni3verma]

No error on my device. Are you running it on emulator? Try again after reinstalling the app.

[vyankatesh24]

No error on my device. Are you running it on emulator? Try again after reinstalling the app.

I have already tried reinstalling.

[Ni3verma]

I am not getting any error.
@Swati4star @sidhuparas please check if you are also getting the error

[vyankatesh24]

I am not getting any error.
@Swati4star @sidhuparas please check if you are also getting the error

Try reinstalling the app. The error comes when you do grayscale PDF for the first time. Then after it's working already.

Your solution is solving one point in issue

• Images shouldn't become grayscale when Cancel is pressed.

[Ni3verma]

Still no error on my device. Please ask other mentors to test on their device.

[Ni3verma]

I just encountered the error...but it was totally random.
I am not able to reproduce it again.
Only thing I did different was that I selected 4 images instead of 2

[sidhuparas]

@Ni3verma Sorry for the delay, will have a look by evening.

[sidhuparas]

@Ni3verma Same. Not working for the first time but then working fine onwards. This is getting repeated on every app restart.

[vyankatesh24]

I just encountered the error...but it was totally random.
I am not able to reproduce it again.
Only thing I did different was that I selected 4 images instead of 2

Are you able to find a solution?

[Ni3verma]

@vyankatesh24
trying to find the problem.

[Ni3verma]

@Ni3verma Same. Not working for the first time but then working fine onwards. This is getting repeated on every app restart.

I was launching the app from recent menu, that's why I was not getting this error. thanks for this info ✌️

[Ni3verma]

@vyankatesh24 @sidhuparas
There is some problem with grayscale transformation of picasso.
See getTarget method in imagesToPdfFragment. It's onBitmapLoaded is not getting called for every image.
I need help here.

[sidhuparas]

@Ni3verma I did some logging and got this in CreatePdf class's doInBackground():
The document has no pages.
This might help a bit. Also the grayscale photos aren't getting removed from Gallery after operation completion.

[Ni3verma]

@sidhuparas I know about this log message. It happens because images are not being converted to grayscale.

[Ni3verma]

@sidhuparas @vyankatesh24 @Swati4star
I need help with this issue

[vyankatesh24]

@sidhuparas @vyankatesh24 @Swati4star
I need help with this issue

Error is with getTarget() method. in saveCurrentImageInGrayscale

[Ni3verma]

@vyankatesh24 @sidhuparas
There is some problem with grayscale transformation of picasso.
See getTarget method in imagesToPdfFragment. It's onBitmapLoaded is not getting called for every image.
I need help here.

@vyankatesh24 I already know about it. guide me how to solve it

[vyankatesh24]

@Ni3verma
What you can do is add Transformed URI to different ArrayList.
Don't remove URIs from mImagesUri in for loop
Outside for loop check, if both are equal in size.
If yes replace mImagesUri ArrayList items
If no reiterate transformation process

[Ni3verma]

Please review it again, now problem should be solved. It is a super hard issue !

[vyankatesh24]

I've tested the changes, the issue is solved.
Well Done @Ni3verma 👍

[Swati4star]

@vyankatesh24 Please merge this