Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add_Watermark on Navigation #[577] #597

Merged
merged 1 commit into from Mar 6, 2019

Conversation

@aqeelparpia
Copy link
Contributor

commented Mar 6, 2019

Description

Added Watermark for Navigation and has the same behaviour as what happens when selected from home page.

Fixes #577
Add Add Watermark option to navigation bar also #577

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle
    I personally ran the project on my emulator. I just had to add the functionality to pull the generated code for Add watermark to the navigation menu.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
Aqeel Parpia Aqeel Parpia
@codeclimate

This comment has been minimized.

Copy link

commented Mar 6, 2019

Code Climate has analyzed commit db6177a and detected 0 issues on this pull request.

View more on Code Climate.

@Swati4star

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2019

@srv-twry review this PR

@Swati4star Swati4star merged commit a2e2c66 into Swati4star:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.