Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong paper sizes for DIN A/B(x) formats in "Set Page Size" dialogue #802

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

laura-callahan
Copy link
Contributor

@laura-callahan laura-callahan commented Oct 7, 2019

Description

@just-Nob pointed out that the DIN A (and also DIN B) listed sizes were incorrect. They were listing 72ppi pixel values, so I've converted them to list mm values so they would be consistent across devices.

Fixes #780

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Made sure that creating a PDF with size restrictions still worked.

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Didn't see anywhere else that referenced those values)
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2019

Code Climate has analyzed commit 73c9fbc and detected 0 issues on this pull request.

View more on Code Climate.

@Swati4star
Copy link
Owner

Great @laurameck

@Swati4star Swati4star merged commit d14e439 into Swati4star:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong paper sizes for DIN A(x) formats in "Set Page Size" dialogue
2 participants