Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in hashing parsed Cargo.lock #159

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fix typo in hashing parsed Cargo.lock #159

merged 1 commit into from
Aug 10, 2023

Conversation

NobodyXu
Copy link
Contributor

This simple mistake caused the entire Cargo.lock to be ignored (JS treats having no return as false).

@NobodyXu
Fix typo in hashing parsed Cargo.lock
72ba19c 
This simple mistake caused the entire `Cargo.lock` to be ignored (JS
treats having no return as `false`).

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Swatinem
Swatinem approved these changes Aug 10, 2023
View reviewed changes
Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I made this mistake quite frequently in Python as well after getting used to Rust :-)

@Swatinem Swatinem merged commit 4e0f4b1 into Swatinem:master Aug 10, 2023
22 checks passed
@NobodyXu NobodyXu deleted the fix branch August 10, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyXu @Swatinem