Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for bioconductor packages #3

Closed
pcm32 opened this issue Jun 30, 2020 · 4 comments
Closed

Support for bioconductor packages #3

pcm32 opened this issue Jun 30, 2020 · 4 comments

Comments

@pcm32
Copy link

pcm32 commented Jun 30, 2020

Thanks for this great action! I tried this in one of our R repos, but it fails becuase the action doesn't consider Bioconductor dependencies I think. Would it be possible to include this in this action? Thanks again!
@pcm32
Copy link
Author

pcm32 commented Jun 30, 2020

This is what I get: https://github.com/ebi-gene-expression-group/internal-ExpressionAtlas/pull/1/checks?check_run_id=822221592

@Swechhya
Copy link
Owner

@pcm32 Thank you for reporting the issue. Yes, currently it does not support Bioconductor dependencies. I'll make changes to accommodate that.

@Swechhya Swechhya mentioned this issue Jul 12, 2020
Merged
@Swechhya
Copy link
Owner

@pcm32 A new version v1.2 has been released to add support for Bioconductor packages.

A new input parameter needsBioc has been added which needs to set to true if there are Bioconductor package dependency. Refer README for additional information.

Closing this issue as this has been addressed. Feel free to reopen it in case of any issues.

@pcm32
Copy link
Author

pcm32 commented Jul 12, 2020

Thanks @Swechhya! I have tried it, works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcm32 @Swechhya