Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trigger and process and mark deprecated functions as such #35

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Remove trigger and process and mark deprecated functions as such #35

merged 3 commits into from
Mar 5, 2024

Conversation

fk3
Copy link
Contributor

@fk3 fk3 commented Mar 5, 2024 •
edited
Loading

  • Removed following semantic functions from EmptyDevice:
    • trigger (use measure instead)
    • process (use process_data to process something before call, or use finish to do cleanup etc.)
  • Other deprecated functions of EmptyDevice (because of naming conventions) will trigger a warning message.
  • A deprecation warning will also show, where from the deprecated function was called

@fk3 fk3 requested a review from a team as a code owner March 5, 2024 14:43
@fk3 fk3 merged commit 2454b8a into main Mar 5, 2024
3 checks passed
@fk3 fk3 deleted the deprecated-functions branch March 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afischer-sweepme afischer-sweepme afischer-sweepme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fk3 @afischer-sweepme