This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Fix document manipulation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
suggested changes
Apr 24, 2020
Fix spelling
mattt
approved these changes
Apr 24, 2020
|
Gut gemacht, @Lukas-Stuehrk! My only feedback had to do with some annoying quirks of English spelling. If nothing else, it was an excuse to do a batched commit of PR suggestions, which worked great. But seriously, kudos for writing some truly excellent tests. And thanks so much for identifying and fixing this issue in the first place. I'm sorry that I missed that cue from cmark's API and neglected to exercise that functionality entirely. Very happy to have this in here now, though. |
|
You're welcome! It was a little bit too late in the evening to proofread English spelling 😴 And I did not know PR suggestions! So thank you for applying, I know a great tool now which I can utilize in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
I'm not entirely happy with the mismatch of
siblingnow. Our sibling is exactly the other node than cmark's sibling. But I did not want to break the existing public API.