Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

fixed ubuntu Illegal Instruction issue #2

Merged
merged 2 commits into from Jul 15, 2020

Conversation

JaapWijnen
Copy link
Contributor

This solves SwiftDocOrg/swift-doc#133
swift-doc itself should be updated to a new version of GraphViz in order for this to work. (plus receive a minor change in a second PR to swift-doc as soon as GraphViz's version is updated)

@mattt
Copy link
Contributor

mattt commented Jul 15, 2020

I can't thank you enough for digging into this, @JaapWijnen. I'm sorry that this ended up causing problems downstream that were hard to pin down. Merging this now and cutting a new release ahead of incorporating your corresponding fix in swift-doc.

@mattt mattt merged commit b4bcd4d into SwiftDocOrg:master Jul 15, 2020
@mattt
Copy link
Contributor

mattt commented Jul 15, 2020

This is fixed in 0.1.2. I'll document this in a proper Changelog soon. (#3)

@JaapWijnen
Copy link
Contributor Author

JaapWijnen commented Jul 15, 2020

Awesome thank you @mattt ! :) I've submitted a PR for fixing swift-doc as well! SwiftDocOrg/swift-doc#140

@JaapWijnen JaapWijnen deleted the ubuntu-illegal-instruction-fix branch July 15, 2020 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants