Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

CSS assets don't reflect swift-doc's versioning #231

Closed
Lukas-Stuehrk opened this issue Mar 28, 2021 · 0 comments · Fixed by #288
Closed

CSS assets don't reflect swift-doc's versioning #231

Lukas-Stuehrk opened this issue Mar 28, 2021 · 0 comments · Fixed by #288
Milestone

Comments

@Lukas-Stuehrk
Copy link
Member

Currently, swift-doc generates the CSS assets by simply downloading the latest version of the minified CSS file from GitHub. This will break old versions once we keep iterating on the CSS and introduce backwards-incompatible changes.

Therefore we should find a way to use the correct version of the CSS files that relates to the version of swift-doc which is used to generate the documentation.

I think the easiest solution is to switch back to get the CSS from the package resources. There was already an attempt in #192. Unfortunately this introduced a lot of issues and needed to be reverted. In the meantime, the minimal Swift version for swift-doc was bumped to Swift 5.3, so from my understanding this approach should be safe now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant