This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Embed generated CSS in Swift raw string literal #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
May 26, 2021
MaxDesiatov
approved these changes
May 26, 2021
Lukas-Stuehrk
approved these changes
May 26, 2021
Write generated CSS to Swift file using raw string literal
mattt
added a commit
that referenced
this pull request
Jun 1, 2021
* Replace postcss CLI usage with custom script Write generated CSS to Swift file using raw string literal * Update README * Update .gitattributes * Update .gitignore * Update validate-assets job in CI workflow * Update generated CSS * Formatting * Consolidate watch scripts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #231
Alternative to #267
As discussed in #267 (comment), this PR takes an alternative approach. Rather than trying to make Swift package resources work, this PR changes our asset pipeline to write directly to a raw string literal constant in a Swift source file, which can be referred to directly in code.