Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.4.0 #77

Merged
merged 3 commits into from
Mar 17, 2018
Merged

Release/2.4.0 #77

merged 3 commits into from
Mar 17, 2018

Conversation

AliSoftware
Copy link
Contributor

No description provided.

@djbe
Copy link
Member

djbe commented Mar 17, 2018

What's the issue with SPM? It can't handle split up files?

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Mar 17, 2018

Remember #63 ?

We found out that there's a bug in SPM (which we reported here on JIRA) depending on file names, and not guaranteeing the order the files were compiled, leading to those kind of errors because the extension was compiled before Filters.Strings was declared


When I ran rake sum:build locally on my machine I got those kind of errors:

/…/StencilSwiftKit/Sources/Filters+Strings+Lettercase.swift:10:19: error: 'Strings' is not a member type of 'Filters'
extension Filters.Strings {
          ~~~~~~~ ^

So I figured it wasn't worth splitting the file

Copy link
Member

@djbe djbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that the issue is outside our control. The actual Jira issue is here: https://bugs.swift.org/browse/SR-631 (the other one is a dupe)

@AliSoftware AliSoftware merged commit ffb22bf into master Mar 17, 2018
@AliSoftware AliSoftware deleted the release/2.4.0 branch March 17, 2018 15:03
@AliSoftware
Copy link
Contributor Author

AliSoftware commented Mar 17, 2018


🎉 Congrats

🚀 StencilSwiftKit (2.4.0) successfully published
📅 March 17th, 16:05
🌎 https://cocoapods.org/pods/StencilSwiftKit
👍 Tell your friends!


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants