Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Swift 3 in Xcode 8 beta 6 #158

Merged
merged 2 commits into from Aug 18, 2016

Conversation

chrisellsworth
Copy link
Collaborator

As of Xcode 8 beta 6, we now get the following build warning for storyboards and fonts:

'where' clause next to generic parameters is deprecated and will be removed in the future version of Swift

Added a swift3 template for fonts and made a change to the swift3 template for storyboards in order to prevent this warning.

@AliSoftware
Copy link
Collaborator

Ace, thanks for the PR!

Could you add an entry in the CHANGELOG to credit yourself and link to this PR? Thanks!

@chrisellsworth
Copy link
Collaborator Author

Done. Thanks! I suspect the tests may fail after #156 is merged in due to the additional fonts. Let me know if you'd like me to correct those when that happens.

@AliSoftware
Copy link
Collaborator

Sure, maybe wait for me to merge #156 … then you can rebase that PR on top of what master would have become after #156 's merge… and fix the potential test failures then!

@AliSoftware
Copy link
Collaborator

AliSoftware commented Aug 17, 2016

In the meantime, I've added you as collaborator on the SwiftGen project to thank you for your contributions — and in an effort to follow Moya contributors guidelines that I plan to adopt officially in a near future.

This will allow you to create branches on SwiftGen directly (instead of doing so on your fork) for your convenience (and also stuff like triaging and labeling PRs and issues).
Use it however you wish (submitting new PRs more easily, helping me maintain SwiftGen… or never using those rights even, it's up to you and this doesn't entails you to any responsibility whatsoever). Just know that the masterbranch is locked so pushing new commits will still have to be done via branches and PRs so that Travis can validate each changes 😉

- Avoid warning about 'where' clause next to generic parameters
@chrisellsworth
Copy link
Collaborator Author

Cool; thank you! I'll try out my new green button right now ⚡

@chrisellsworth chrisellsworth merged commit 024ea2e into SwiftGen:master Aug 18, 2016
@AliSoftware
Copy link
Collaborator

Time for 🎉 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants