Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String template: use enum instead of struct #218

Merged
merged 1 commit into from Nov 30, 2016
Merged

String template: use enum instead of struct #218

merged 1 commit into from Nov 30, 2016

Conversation

djbe
Copy link
Member

@djbe djbe commented Nov 29, 2016

Mirrors template changes in #206.

@djbe djbe changed the title modify template and expected test result String template: use enum instead of struct Nov 29, 2016
@djbe djbe added this to the Next patch (4.0.1) milestone Nov 29, 2016
@AliSoftware
Copy link
Collaborator

AliSoftware commented Nov 29, 2016 •
edited

Repo info: Just added a new status: Ready to merge flag to this repo in addition to all the others, as a lot of PRs are almost ready, even approved, but just waiting for CI (especially since Travis might sometimes take some time to complete — they had a shortage again recently, still catching up the OSX builds — and GitHub doesn't yet signal "Approved" PRs clearly in the "Pull Requests" tab/list to identify approved PRs quickly there, so the tag will help for that purpose too)

@djbe djbe merged commit d1dfbcc into SwiftGen:master Nov 30, 2016
@djbe djbe deleted the feature/strings-enum-namespacing branch November 30, 2016 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next patch (4.0.1)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djbe @AliSoftware