Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SwiftLint « switch_case_on_newline » warning in colors templates #239

Merged
merged 4 commits into from Dec 12, 2016
Merged

Fix SwiftLint « switch_case_on_newline » warning in colors templates #239

merged 4 commits into from Dec 12, 2016

Conversation

MickaCapi
Copy link
Contributor

@MickaCapi MickaCapi commented Dec 12, 2016 •
edited

Fix Issue #238

@MickaCapi MickaCapi closed this Dec 12, 2016
@djbe djbe reopened this Dec 12, 2016
@djbe
Copy link
Member

djbe commented Dec 12, 2016

Todo:

  • Update the expected output files.
  • Changelog entry, see the format of the previous entries.

Edit: while I wrote this you did the first item

AliSoftware
AliSoftware previously requested changes Dec 12, 2016
View reviewed changes
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a CHANGELOG entry to credit yourself, otherwise 👌

@djbe
Copy link
Member

djbe commented Dec 12, 2016

Please add a . and 2 spaces at the end of the changelog entry, so that the rest appears on a newline (markdown stuff).

@djbe djbe merged commit 6382fc3 into SwiftGen:master Dec 12, 2016
@djbe djbe added this to the 4.1.0 milestone Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MickaCapi @djbe @AliSoftware