Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.0.0 #509

Merged
merged 8 commits into from Sep 28, 2018
Merged

Release 6.0.0 #509

merged 8 commits into from Sep 28, 2018

Conversation

djbe
Copy link
Member

@djbe djbe commented Sep 27, 2018

I've moved the "bug fixes" changelog section to be after "new features". I've adapted the rake script as well. The order is now:

  • Breaking changes
  • New features
  • Bug fixes
  • Internal changes

@AliSoftware
Copy link
Collaborator

I'll do a PR to link to the new wiki page about swiftlint custom rules before we merge this PR

@AliSoftware
Copy link
Collaborator

(We should also include #508 in this release)

@djbe djbe added this to the Swiftgen 6.0 milestone Sep 27, 2018
@AliSoftware AliSoftware mentioned this pull request Sep 28, 2018
6 tasks
@djbe djbe force-pushed the release/6.0.0 branch 2 times, most recently from 4f1315b to cf4f408 Compare September 28, 2018 18:45
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be the best occasion to update our internal release process doc in our wiki (which is supposed to serve as a guide to ourselves, really): https://github.com/SwiftGen/SwiftGen/wiki/%5BAdmin%5D-Release-Process

Tests/SwiftGenTests/ConfigLintTests.swift Show resolved Hide resolved
@djbe
Copy link
Member Author

djbe commented Sep 28, 2018

I've updated the Update the version of SwiftGen section in that wiki page. I'm not familiar enough with the release process to update the Publish a new release accordingly.

@djbe
Copy link
Member Author

djbe commented Sep 28, 2018

@AliSoftware right, so I wrongly assumed that the CLI template name option was called --templateName when I updated the error messages and docs (it's called --template).

We can either leave them as is, or add new options that match those docs and deprecate the old one (see last commit 05e0b88). Not sure if that warrants a mention in the MG, as the old option is still around.

@AliSoftware
Copy link
Collaborator

Wait seriously? It was still --template the whole time?
I say we rename it to match the config file and mark the old one as deprecated

@AliSoftware
Copy link
Collaborator

So iiuc basically what you did in the last commit, right?

@djbe
Copy link
Member Author

djbe commented Sep 28, 2018

Jep.

@djbe
Copy link
Member Author

djbe commented Sep 28, 2018

Question is: changelog entry and MG entry? Or skip 'em?

@AliSoftware
Copy link
Collaborator

CHANGELOG entry I think yes, we need to trace that somewhere at least. MG entry probably not worth it, the overall suggestion in the MG already being basically "Y U Not use a config file already?" anyway 😜

@AliSoftware
Copy link
Collaborator

TODO: Update the playground + rakelib/playground.rake since we recently renamed the YAML resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants