Git Add #127
Merged
Git Add #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
requested changes
May 1, 2018
SwiftGit2/Repository.swift
Outdated
| @@ -583,6 +583,33 @@ final public class Repository { | |||
| return iterator | |||
| } | |||
|
|
|||
| /// Get the index for the repo. The caller is responsible for freeing the index. | |||
| public func unsafeIndex() -> Result<OpaquePointer, NSError> { | |||
There was a problem hiding this comment.
Let's not make this public. Unsafe operation should be kept internal.
|
This looks good apart from the one note above! |
|
@mdiep made that change! |
mdiep
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdiep This is the second PR after Swift 4.1 implementing
git addby path. Once #126 is merged I can rebase this on top of master.