Git commit #128
Merged
Git commit #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind rebasing or merging in master? 🙏 |
mdiep
reviewed
May 2, 2018
SwiftGit2/Objects.swift
Outdated
|
|
||
| /// Return an unsafe pointer to the `git_signature` struct. | ||
| /// Caller is responsible for freeing it with `git_signature_free`. | ||
| var unsafeSignature: Result<UnsafeMutablePointer<git_signature>, NSError> { |
There was a problem hiding this comment.
It think we should probably make this a makeX function. That'd be more in line with the Swift API guidelines. makeUnsafeSignature(). Or maybe even makeGitSignature().
There was a problem hiding this comment.
makeUnsafeSignature() sounds more consistent with our current unsafe-prefix stuff
…ick up the new index
|
@mdiep done |
mdiep
requested changes
May 4, 2018
| let lookupResult = git_commit_lookup(&parent, self.pointer, &oid) | ||
| guard lookupResult == GIT_OK.rawValue else { | ||
| let err = NSError(gitError: lookupResult, pointOfFailure: "git_commit_lookup") | ||
| return .failure(err) |
There was a problem hiding this comment.
This would leak parentGitCommits. We need a defer above that frees them.
There was a problem hiding this comment.
Doesn't a defer free the commit as soon as it goes out of scope i.e. the for loop?
There was a problem hiding this comment.
nvm I think I found a way
| // should be clean now | ||
| let newStatus = repo.status() | ||
| expect(newStatus.value?.count).to(equal(0)) | ||
| } |
|
Looks good apart from this. |
|
Thanks for taking the time to review! |
mdiep
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay this one works but is definitely not as clean as I wanted. And there are way too many levels of nesting. Thoughts?