Add support for view controller presentation #198
Conversation
SwiftMessages/Animator.swift
Outdated
|
|
||
| var showDuration: TimeInterval? { get } | ||
|
|
||
| var hideDuration: TimeInterval? { get } |
There was a problem hiding this comment.
Why Optional? Why not a default value of 0? What does nil mean in this case?
There was a problem hiding this comment.
nil would mean that the duration is unknown, such as if the animation was being provided by UIDynamicAnimator.
There was a problem hiding this comment.
I think it could be helpful to explain that in a comment, since it's a public API and not immediately obvious (at least to me).
SwiftMessages/BaseView.swift
Outdated
| /* | ||
| MARK: - Drop shadow | ||
| */ | ||
|
|
SwiftMessages/StoryboardSegue.swift
Outdated
| import UIKit | ||
|
|
||
| /** | ||
| A configurable `UIStoryboardSegue subclass that utilizes SwiftMessages to |
There was a problem hiding this comment.
Missing a backtick after UIStoryboardSegue?
SwiftMessages/StoryboardSegue.swift
Outdated
| public var containment: Containment = .content | ||
|
|
||
| /** | ||
| Specifies how much the view controller's view is inset from it's superview |
SwiftMessages/StoryboardSegue.swift
Outdated
| set { messenger.defaultConfig.presentationStyle = newValue } | ||
| } | ||
|
|
||
| // The dim mode to use. See the SwiftMessages.DimMode documentation for details. |
There was a problem hiding this comment.
The comment here and on presentationStyle should be ///?
SwiftMessages/StoryboardSegue.swift
Outdated
| extension StoryboardSegue { | ||
| private class Shower: NSObject, UIViewControllerAnimatedTransitioning { | ||
|
|
||
| fileprivate private(set) var completeTransition: ((_: Bool) -> Void)? |
There was a problem hiding this comment.
Is the _: in completeTransition: ((_: Bool) -> Void)? needed? Can it just be completeTransition: ((Bool) -> Void)??
…bile/SwiftMessages into work/viewControllers # Conflicts: # SwiftMessages/SwiftMessagesSegue.swift
Had to do this to work with Carthage due to a bug Carthage/Carthage#2549
…bile/SwiftMessages into work/viewControllers
…bile/SwiftMessages into work/viewControllers
…bile/SwiftMessages into work/viewControllers
No merge please. Just comments.