Add orientation to config #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ullstrm
commented
Nov 1, 2022
Comment on lines
+322
to
+324
| If a view controller is created to host the message view, which interface | ||
| orientation should it support? The default is 'nil', meaning it will use the | ||
| default value for UIViewController in the current environment. |
There was a problem hiding this comment.
This comment has similar wording as the shouldAutorotate-property.
|
Hello, First of all, thank you very much for the solution. We are also having problems using shouldAutorotate on iOS16 devices in our application. When we tried this solution, we found it worked. Could you please approve the merge of the pull request into the code? |
|
Sorry, I missed this PR. SwiftMessages already provides a way to supply a custom config.windowViewController = { config in return MyWindowViewController(config: config) }This is preferred over trying to put every possibly feature that might be needed into |
rmucenieks
pushed a commit
to rmucenieks/SwiftMessages
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using this code, we can solve the problems we have had on iOS16 with SwiftMessages not respecting the
shouldAutorotateproperty.