Add new apps and fixed a typo in MessagesTest.swift

[Maryom]

Salam :)

I added Sonos, Videos, OneDrive, and Outlook. I would like to add more apps for Microsoft I think it will be a great idea do you agree with me?

But the problem is app path I think it not suite with Appz, Do you agree?
This is what I found from documentation:
https://msdn.microsoft.com/en-us/library/office/dn911482.aspx
https://msdn.microsoft.com/it-it/library/office/dn906146.aspx#sectionSection9

I tried to add OneNote, Word, Excel, and PowerPoint all of them opened but they keep showing a warning message that I have to open them with a specific file.

It's easy to do it as I found in the above links, like this:
Schema format:
|u||p||c|
The following example shows a request to invoke a Word file for editing:
ms-word:ofe|u|https://contoso/Q4/budget.docx|p|clouddrive|c|folderviewQ4

But what should we do with ofe|u| we have instead of it //app, Any suggestions?
Thanks ..

[Mazyod]

Hi, thanks for adding these, I think they will be a valuable addition to Appz!

I fully understand your concern about the format of the URL, and it can easily be fixed. Appz is a very flexible and modular library, and you'll see how in a bit. This is not a trivial task, and will require some thought and design process, so be prepared for that :)

Instead of trying to make the parameters passed into the action directly, we can add a new struct to build the URL for us:

public struct MSPayload {
    public var url: String
    public var passback: String? = nil
    public var context: String? = nil

    public func buildURL() -> String {
        var sections = [("u", url)]
        if let passback = passback {
            sections.append(("p", passback))
        }
        if let context = context {
            sections.append(("c", context))
        }
        // convert tuples to "|x|string", then join them
        return sections.map { "|\($0.0)|\($0.1)" }.joinWithSeparator("")
    }
}

Then, you can make the user pass in a MSPayload to the MS apps:

enum Action {
    case Open(MSPayload)
}
...
switch action {
case .Open(let payload):
    return payload.buildURL()
}

I apologize for any mistakes, I wrote this directly on github, but I think it's enough to get the idea. I hope this helps, and you can try to write tests for the buildURL function as well.

[Maryom]

@Mazyod Great suggestion, thanks :) I will try to add it.

[Mazyod]

I don't have an account, unfortunately. Azerbaijan is a nice country, you can leave it as it is and create an account :) ?

[Maryom]

@Mazyod When I sent you my question, the web suddenly worked with Kuwait that why I deleted it. Thanks for your fast reply 🚀

[Maryom]

@Mazyod Can I tell you the problem?

[Mazyod]

@Maryom Sure, what happened?

[Maryom]

@Mazyod Thank you so much. I was trying to get the direct URL for a document for 2 hours 🙃 all my tries failed. I understand this:
ms-word:ofe|u|https://contoso/Q4/budget.docx|p|clouddrive|c|folderviewQ4

From the document I understand that these are optional: |p|clouddrive|c|folderviewQ4

So no need for them, I removed them and this what I get in Xcode:
url Optional(ms-word://ofe%7Cu%7Chttps%3A%2F%2Fd.docs.live.net%2Ffa74248df401c361%2Ffun.docx)

It looks great but I can't figure why it still not working?

[Maryom]

@Mazyod From this blog, I thought I have to use Office 365
http://blog.beecomedigital.com/2015/02/16/opening-a-document-with-office-mobile-from-your-own-application/

But when I used it nothing is change!

In the above post, from where they got this URL: https://tenant.sharepoint.com/Shared%20Documents/Document.docx

[Maryom]

@Mazyod I tried right click share, and I tried to email it to myself and I tried embedded link all links didn't work.

[Mazyod]

@Maryom Thanks, I'll try to look into this soon

[Maryom]

@Mazyod I think no need to look at it, because I noticed that in MS apps if you try to open for example a word file in one drive app it will open perfectly but not directly it shows downloading and then open it. Do you agree with me? I wish I can record it for you but it's on my iPhone.

[Maryom]

@Mazyod Like this pic.

[Mazyod]

@Maryom You can always push basic working implementation, then we can iterate on it to make it better 👷

[Maryom]

@Mazyod Also, I was thinking that no need for // because in the document there is no // after ms-word:

ms-word:ofe|u|https://contoso/Q4/budget.docx|p|clouddrive|c|folderviewQ4

So I removed them but it not working at all
This is the URL without //
ms-word:ofe%7Cu%7Chttps%3A%2F%2Fd.docs.live.net%2Ffa74248df401c361%2Ffun.docx

[Maryom]

@Mazyod Do you suggest to PR with it even it showing warning message? it's really bad PR, because I couldn't solve the problem 😔

[Mazyod]

@Maryom Yeah, the double slash is always required. It's fine, I will not make a release until we make this working. merging a PR doesn't mean we will make a new release :)

[Maryom]

@Mazyod Ok I will try more until 12:00 am if it not working I will PR. I have a note on Mail.swift in public struct Email I think init should be public:

public init(recipient: String = "", subject: String = "", body: String = "") {

    self.recipient = recipient
    self.subject = subject
    self.body = body
}

This is the error when it not public:

But when I made public it worked fine, Do you agree with me?

[Mazyod]

@Maryom Yeah, Email init should definitely be public

[Maryom]

@Mazyod إن شاء الله I will fix it with the next PR. Thank you for being there while I'm lost! I hope I can fix my problem by myself so that I give something useful ..

[Mazyod]

@Maryom Thanks for pushing this, I'll look into why it's not working, I'm sure it's just a small problem with a configuration somewhere

[Maryom]

@Mazyod Your welcome. This just pop up, what should I do?

[Mazyod]

@Maryom I don't know, maybe you should reload the browser or something?

[Maryom]

@Mazyod Me too I don't know. I hope you delivered the PR. If not please tell me to resend it.