Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting #49

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix sorting #49

merged 1 commit into from
Sep 19, 2023

Conversation

finestructure
Copy link
Member

I noticed this (which is what we discussed the other day) while debugging an unrelated problem with our nightly: apply-deny-list changes the sorting of the original package list when it subtracts the deny list.

Here's the before and after of a snippet:

packages.json before deny list
[
  ...
  "https://github.com/swift-server-community/APNSwift.git",
  "https://github.com/swift-server-community/mqtt-nio.git",
  "https://github.com/swift-server/async-http-client.git",
  "https://github.com/swift-server/RediStack.git",
  "https://github.com/swift-server/security.git",
  ...
]
packages.json after deny list
[
  ...
  "https://github.com/swift-server-community/APNSwift.git",
  "https://github.com/swift-server-community/mqtt-nio.git",
  "https://github.com/swift-server/RediStack.git",
  "https://github.com/swift-server/async-http-client.git",
  "https://github.com/swift-server/security.git",
  ...
]

Notice how async-http-client.git and RediStack.git are trading places.

This is likely the source of the big delta we've been seeing.

@finestructure finestructure merged commit 65f512c into main Sep 19, 2023
3 checks passed
@finestructure finestructure deleted the fix-sorting branch September 19, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants