Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https://gitlab.com/mattt/CommonMarkAttributedString #878

Closed
wants to merge 2 commits into from
Closed

Conversation

mattt
Copy link

@mattt mattt commented Jan 20, 2021

The package(s) being submitted are:

Checklist

I have either:

  • Run swift ./validate.swift.

Or, checked that:

  • The package repositories are publicly accessible.
  • The packages all contain a Package.swift file in the root folder.
  • The packages are written in Swift 4.0 or later.
  • The packages all contain at least one product (either library or executable), and at least one product is usable in other Swift apps.
  • The packages all have at least one release tagged as a semantic version.
  • The packages all output valid JSON from swift package dump-package with the latest Swift toolchain.
  • The package URLs are all fully specified including the protocol (usually https) and the .git extension.
  • The packages all compile without errors.
  • The package list JSON file is sorted alphabetically.

Copy link
Member

@daveverwer daveverwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mattt!

I see there's both the GitLab repo and a GitHub repo in this PR. Unfortunately, until we get SwiftPackageIndex/SwiftPackageIndex-Server#485 implemented it's not possible to merge this as-is.

It looks like the GitHub repo is a mirror of the GitLab repo (or vice versa)? Maybe we could add the GitHub version for now and once we support GitLab, switch over to that? Is there a reason you wanted both in the index? It does look like a mirror situation at a first glance.

Thanks for the submission! I'm sorry we couldn't just merge it 😅

@Sherlouk Sherlouk mentioned this pull request Jan 21, 2021
@daveverwer
Copy link
Member

I created #884 so we could get this package into the index. Happy to chat more about the GitLab issue, or the duplicate package issue if there's anything to say.

Thanks for the addition, Mattt!

@daveverwer daveverwer closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants