Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace swift package dump-package with swift package describe --type json #1172

Open
finestructure opened this issue Jun 14, 2021 · 5 comments

Comments

@finestructure
Copy link
Member

describe is going to replace dump-package in the future and has more information. For instance c99name and module_membership, which we need for package collections.

@finestructure
Copy link
Member Author

As part of this issue, make sure to migrate the changes made in #1171 over to use data from describe.

@finestructure finestructure self-assigned this Jun 14, 2021
@daveverwer
Copy link
Member

daveverwer commented Mar 1, 2022

I was just chatting with @maxxfrazer about an issue he's having with generating a package collection and it became clear that we should approach this change with some caution as there are packages that output from dump-package without issues that fail with describe.

For example AgoraRtcKit:

$ swift package dump-package
{
  "cLanguageStandard" : null,
  "cxxLanguageStandard" : null,
  "dependencies" : [

  ],
  "name" : "AgoraRtcKit",
  ... etc ...

But with describe:

$ swift package describe --type json
error: artifact not found for target 'AgoraAIDenoiseExtension'

Max thinks it's because that package (and others where the same issue happens) only have binary targets, which we currently have no problems with.

He logged a bug with this last year and we should probably wait until that’s fixed and shipped before making this change.

@finestructure finestructure removed their assignment May 20, 2022
@daveverwer
Copy link
Member

@maxxfrazer let me know that this bug has now been fixed.

I think the 5.7 releases have already been frozen, but let's keep an eye on this for 5.8/6.0.

@maxxfrazer
Copy link
Contributor

This is the issue I was looking for!

It does work with the 5.7 snapshot I tried; the 2022-05-18 build.
Once Swift 5.7 is released the fix should already be in there.

@ykhandelwal913
Copy link

Any idea when 5.8/6.0 going to release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants