Issue 2551 check dependencies failure

[finestructure]

I believe this changed when we adopted Swift 5.9 for validation. There's been a subtle format change in the package dump json from

          "location" : {
            "remote" : [
              "https://github.com/apple/swift-argument-parser"
            ]
          },

to

          "location" : {
            "remote" : [
              {
                "urlString" : "https://github.com/JohnSundell/Ink.git"
              }
            ]
          },

which tripped us up. We're now supporting both versions.

I've made a note to try and detect changes like this somehow between Swift versions.

Fixes SwiftPackageIndex/SwiftPackageIndex-Server#2551

[daveverwer]

We could have a snapshot test of the output from dump-package run on a non-trivial package. There would be a lot of artefacts for that test, and it might be slow to run, so it could even be a separate CI stage that just does that one job, and only run on CI, maybe.

[daveverwer]

I'm not sure what the up-to-date plans are with deprecating dump-package are at this stage, but we still have #1172 hanging over our heads as well.

[finestructure]

❯ swift run validator check-dependencies -i test.json
Building for debugging...
[444/444] Linking validator
Build complete! (5.57s)
Warning: Using anonymous authentication -- you will quickly run into rate limiting issues

Cache loaded (0 entries)
Checking dependencies (1 packages) ...
Dependencies for https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server.git ...
  - https://github.com/JohnSundell/Ink.git
  - https://github.com/swift-server-community/SwiftPrometheus.git
  - https://github.com/SwiftPackageIndex/DependencyResolution.git
  - https://github.com/SwiftPackageIndex/SPIManifest.git
  - https://github.com/SwiftPackageIndex/SemanticVersion.git
  - https://github.com/apple/swift-package-manager.git
  - https://github.com/dankinsoid/VaporToOpenAPI.git
  - https://github.com/pointfreeco/swift-custom-dump.git
  - https://github.com/pointfreeco/swift-parsing.git
  - https://github.com/pointfreeco/swift-snapshot-testing.git
  - https://github.com/scinfu/SwiftSoup.git
  - https://github.com/soto-project/soto.git
  - https://github.com/vapor/fluent-postgres-driver.git
  - https://github.com/vapor/fluent.git
  - https://github.com/vapor/vapor.git

[finestructure]

We could have a snapshot test of the output from dump-package run on a non-trivial package. There would be a lot of artefacts for that test, and it might be slow to run, so it could even be a separate CI stage that just does that one job, and only run on CI, maybe.

Yeah, although we'd have to do that in SPI-Server, not here, because we hardly ever update validator and wouldn't notice.

[daveverwer]

Yeah, although we'd have to do that in SPI-Server, not here, because we hardly ever update validator and wouldn't notice.

Yes, sorry. I didn't say it, but I meant for it to be in the context of SPI-Server 👍 That way, as the base image moves forward, we're covered