Skip to content

Commit

Permalink
fix(engine-prime): build-failure
Browse files Browse the repository at this point in the history
Explicitly instantiate default destructor in out-of-line (in .cpp)
because destructing a `std::unique_ptr<Waveform>` needs `Waveform`
to be complete at the point of destruction.
  • Loading branch information
Swiftb0y committed Jun 24, 2024
1 parent 985b121 commit 04ac735
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/library/export/engineprimeexportjob.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,10 @@ EnginePrimeExportJob::EnginePrimeExportJob(
}
}

// out-of-line declaration because we can't generate dtor in
// header with unique_ptr's of incomplete types.
EnginePrimeExportJob::~EnginePrimeExportJob() = default;

void EnginePrimeExportJob::loadIds(const QSet<CrateId>& crateIds) {
DEBUG_ASSERT_QOBJECT_THREAD_AFFINITY(m_pTrackCollectionManager);

Expand Down
2 changes: 2 additions & 0 deletions src/library/export/engineprimeexportjob.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ class EnginePrimeExportJob : public QThread {
TrackCollectionManager* pTrackCollectionManager,
QSharedPointer<EnginePrimeExportRequest> pRequest);

virtual ~EnginePrimeExportJob() override;

/// Run the export job.
void run() override;

Expand Down

0 comments on commit 04ac735

Please sign in to comment.