Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Weird localization words order in onboarding title screen. #158

Conversation

Uhucream
Copy link
Contributor

@Uhucream Uhucream commented May 26, 2023

About this Pull Request

This pull request fixed a problem that onboarding title words order was wrong on Japanese.

What was the problem?

The Japanese localization of "onboarding.title" should be "Swiftcord へようこそ" but because of a localization interpolation code was wrong, so it had been shown "へようこそ Swiftcord".

スクリーンショット 2023-05-26 午後6 05 50_before



To convey that the word order in "へようこそ Swiftcord" is grammatically incorrect in Japanese, you can use the following translation in English like this:

Translation: Swiftcord to welcome .

I hope you realize such weird words order.

Screenshots (Before and After)

This section also stands for proving there are no regressions.

Before After
Chinese, Simplified スクリーンショット 2023-05-26 午後6 07 19_before スクリーンショット 2023-05-26 午後6 19 09
Chinese, Traditional スクリーンショット 2023-05-26 午後6 07 54_before スクリーンショット 2023-05-26 午後6 19 47
Dutch スクリーンショット 2023-05-26 午後6 08 27_before スクリーンショット 2023-05-26 午後6 20 29
English スクリーンショット 2023-05-26 午後6 06 50_before スクリーンショット 2023-05-26 午後6 21 08
French スクリーンショット 2023-05-26 午後6 09 47_before スクリーンショット 2023-05-26 午後6 21 34
German スクリーンショット 2023-05-26 午後6 10 11_before スクリーンショット 2023-05-26 午後6 21 59
Hebrew スクリーンショット 2023-05-26 午後6 10 36_before スクリーンショット 2023-05-26 午後6 22 37
Italian スクリーンショット 2023-05-26 午後6 10 59_before スクリーンショット 2023-05-26 午後6 24 10
Japanese スクリーンショット 2023-05-26 午後6 05 50_before スクリーンショット 2023-05-26 午後6 25 13
Korean スクリーンショット 2023-05-26 午後6 11 59_before スクリーンショット 2023-05-26 午後6 26 00
Norwegian Bokmål (Norway) スクリーンショット 2023-05-26 午後6 12 28_before スクリーンショット 2023-05-26 午後6 26 56
Polish スクリーンショット 2023-05-26 午後6 14 18_before スクリーンショット 2023-05-26 午後6 27 31
Russian スクリーンショット 2023-05-26 午後6 14 40_before スクリーンショット 2023-05-26 午後6 27 59
Turkish スクリーンショット 2023-05-26 午後6 15 03_before スクリーンショット 2023-05-26 午後6 28 27

References

https://www.kodeco.com/29501177-attributedstring-tutorial-for-swift-getting-started

https://gist.github.com/mattyoung/5be253f8dc7ac924f23362472c5e3344

@Uhucream Uhucream marked this pull request as ready for review May 26, 2023 11:03
@Uhucream Uhucream changed the title Fix: Odd localization words order in onboarding title screen. Fix: Weird localization words order in onboarding title screen. May 26, 2023
@Uhucream
Copy link
Contributor Author

Uhucream commented Jun 5, 2023

@cryptoAlgorithm

By the way, I'd confirmed translations correctness of this fix with ChatGPT and DeepL.

@cryptoAlgorithm
Copy link
Member

Haha that's hilarious! 😂 These look good, but I'll need to take some time to ensure merging these don't completely screw up contributions from Weblate (which are already messed up as is). Sorry for the delay, and thanks for your efforts for bringing swiftcord to more languages!

@Uhucream
Copy link
Contributor Author

Uhucream commented Jun 7, 2023

@cryptoAlgorithm

Haha that's hilarious! 😂 These look good, but I'll need to take some time to ensure merging these don't completely screw up contributions from Weblate (which are already messed up as is). Sorry for the delay, and thanks for your efforts for bringing swiftcord to more languages!

Thanks for confirming this pull request!

I see. It's good timing because I've wanted to refactor styling logic of Swiftcord string to simpler way!

So I work it until these correct translation is coming.

@Uhucream
Copy link
Contributor Author

Uhucream commented Jun 7, 2023

@cryptoAlgorithm

I worked the refactor for styling Swiftcord string on 90d7a7e.

I'd used the emphasize clause to style string but we shouldn't do that.
Because translators should not be known string styles on point of view of domain-driven development.

This fix has benefits below.

  • Eliminate a mistakes that translators forget insert emphasize clause (** **).
  • Less codes.

@cryptoAlgorithm cryptoAlgorithm added this pull request to the merge queue Jun 18, 2023
Merged via the queue into SwiftcordApp:main with commit b5a38c0 Jun 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants