Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extensions with failing tests #1122

Closed
wants to merge 1 commit into from

Conversation

viktart
Copy link
Contributor

@viktart viktart commented Jul 19, 2023

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 5.0.
  • New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.39 🎉

Comparison is base (23d8a18) 92.41% compared to head (6093863) 94.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
+ Coverage   92.41%   94.80%   +2.39%     
==========================================
  Files         107      106       -1     
  Lines        3862     3851      -11     
==========================================
+ Hits         3569     3651      +82     
+ Misses        293      200      -93     
Flag Coverage Δ
ios 94.82% <ø> (-0.02%) ⬇️
macos 96.45% <ø> (+13.33%) ⬆️
tvos 57.04% <ø> (-37.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/SwifterSwift/UIKit/UIViewExtensions.swift 83.01% <ø> (-0.44%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SwifterSwiftBot
Copy link

1 Warning
⚠️ The source files have been modified. Please consider adding a CHANGELOG entry if necessary.
1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

@guykogus
Copy link
Contributor

@viktart why delete these? I didn't see them failing last time I tested. Can't you fix them?
Also, if these functions are no longer fixable/usable, also make sure to update the Changelog

@viktart
Copy link
Contributor Author

viktart commented Jul 29, 2023

@guykogus It's probably related to M1 processor (I have a Mac with M1 processor)
UIDatePicker extension is sketchy anyway withsetValue(newValue, forKeyPath: "textColor")
As for UIView rotate() extension, I haven't check if it still works, but the failing test is probably related to floating point accuracy

@guykogus
Copy link
Contributor

Replacing with #1136

@guykogus guykogus closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants