Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added product() and product(for:) methods to Sequence #1168

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

MartonioJunior
Copy link
Contributor

🚀

Added product() and product(for:) methods for multiplying elements and properties in a sequence (standalone PR as requested on #1167).

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 5.6.
  • New extensions support iOS 12.0+ / tvOS 12.0+ / macOS 10.13+ / watchOS 4.0+, or use @available if not.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

Copy link
Member

@LucianoPAlmeida LucianoPAlmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8aee67) 95.89% compared to head (600a7a4) 95.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1168   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         107      107           
  Lines        3966     3969    +3     
=======================================
+ Hits         3803     3806    +3     
  Misses        163      163           
Flag Coverage Δ
ios 95.40% <100.00%> (+<0.01%) ⬆️
macos 96.53% <100.00%> (+<0.01%) ⬆️
tvos 94.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SwifterSwiftBot
Copy link

1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

@LucianoPAlmeida LucianoPAlmeida merged commit cf79269 into SwifterSwift:master Jan 30, 2024
10 checks passed
@MartonioJunior MartonioJunior deleted the sequence-product branch February 10, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants