Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSStackView.addArrangedSubviews and NSStackView.removeArrangedSubviews #1181

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

RomanPodymov
Copy link
Contributor

🚀
Hello.
Thank you for SwifterSwift.
Fixed #1180.

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 5.6.
  • New extensions support iOS 12.0+ / tvOS 12.0+ / macOS 10.13+ / watchOS 4.0+, or use @available if not.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.13%. Comparing base (ca24eef) to head (03864d1).

Files Patch % Lines
...es/SwifterSwift/AppKit/NSStackViewExtensions.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage   93.27%   93.13%   -0.15%     
==========================================
  Files         107      108       +1     
  Lines        3969     3975       +6     
==========================================
  Hits         3702     3702              
- Misses        267      273       +6     
Flag Coverage Δ
ios 95.60% <ø> (ø)
macos 83.18% <0.00%> (-0.20%) ⬇️
tvos 96.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SwifterSwiftBot
Copy link

1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

CHANGELOG.md Outdated Show resolved Hide resolved
RomanPodymov and others added 3 commits March 31, 2024 18:14
Co-authored-by: Guy Kogus <guy.kogus@gmail.com>
@guykogus guykogus merged commit a3990c3 into SwifterSwift:master Apr 1, 2024
8 of 10 checks passed
RomanPodymov added a commit to RomanPodymov/RomanPodymov that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSStackView.addArrangedSubviews and NSStackView.removeArrangedSubviews
4 participants