Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate SPM packages #1187

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Create separate SPM packages #1187

wants to merge 1 commit into from

Conversation

guykogus
Copy link
Contributor

@guykogus guykogus commented Apr 11, 2024

🚀

Fixes #1023

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 5.6.
  • New extensions support iOS 12.0+ / tvOS 12.0+ / macOS 10.13+ / watchOS 4.0+, or use @available if not.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

@guykogus guykogus marked this pull request as draft April 11, 2024 20:52
@guykogus guykogus changed the title Draft: Create separate SPM packages Create separate SPM packages Apr 11, 2024
@guykogus
Copy link
Contributor Author

@LucianoPAlmeida what do you think? I was wondering if maybe we need to completely refactor it out so that each extension package exists in a separate folder. I.e. at the root of the project have SwifterSwift-AppKit/Sources/*. This seems to work, too, but it's another option.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (39fa28c) to head (4239878).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
+ Coverage   93.17%   95.92%   +2.74%     
==========================================
  Files         108      108              
  Lines        4002     4002              
==========================================
+ Hits         3729     3839     +110     
+ Misses        273      163     -110     
Flag Coverage Δ
ios 95.63% <ø> (ø)
macos 96.58% <ø> (+13.22%) ⬆️
tvos 94.27% <ø> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SwifterSwiftBot
Copy link

2 Warnings
⚠️ Consider adding tests for new extensions or updating existing tests for a modified SwifterSwift extension
⚠️ The source files have been modified. Please consider adding a CHANGELOG entry if necessary.
1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

@LucianoPAlmeida
Copy link
Member

@LucianoPAlmeida what do you think? I was wondering if maybe we need to completely refactor it out so that each extension package exists in a separate folder. I.e. at the root of the project have SwifterSwift-AppKit/Sources/*. This seems to work, too, but it's another option.

I think this is fine if that works and such a refactor will be much work for no much value if the way it is serves the purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Package.swift to support sub modules
3 participants