Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typo in UICollectionViewExtensions and UITableViewExtensions #137

Conversation

ShivaHuang
Copy link
Member

All functions with prefix deque should be dequeue.

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • I have only one commit in this pull request.
  • New extensions support iOS 8 or later.
  • New extensions are written in Swift 3.
  • I have added tests for new extensions, and they passed.
  • Pull request was created to master head branch.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All comments headers have the word SwifterSwift: before description.

All functions with prefix `deque` should be `dequeue`.
@codecov
Copy link

codecov bot commented Mar 22, 2017

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is 89.47%.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   88.61%   88.61%           
=======================================
  Files          75       75           
  Lines        4303     4303           
=======================================
  Hits         3813     3813           
  Misses        490      490
Impacted Files Coverage Δ
.../Extensions/UIKit/UICollectionViewExtensions.swift 57.14% <0%> (ø) ⬆️
...itExtensionsTests/UITableViewExtensionsTests.swift 94.04% <100%> (ø) ⬆️
...ource/Extensions/UIKit/UITableViewExtensions.swift 93.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f686b...ecd376e. Read the comment docs.

@omaralbeik omaralbeik merged commit c810f23 into SwifterSwift:master Mar 22, 2017
@omaralbeik
Copy link
Member

Thank you @ShivaHuang!

@SD10
Copy link
Member

SD10 commented Mar 22, 2017

Thank you @ShivaHuang. This closes #136. I'll update the docs in a few hours from now.

@ShivaHuang ShivaHuang deleted the Fix_Typo_in_UICollectionViewExtensions_UITableViewExtensions branch March 23, 2017 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants