Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some other array extensions #516

Merged
merged 4 commits into from Jul 14, 2018

Conversation

LucianoPAlmeida
Copy link
Member

Continuation of #512
Still related to #427, hope to find time to take a more detailed look :))

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 4.
  • New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

@codecov
Copy link

codecov bot commented Jul 14, 2018

Codecov Report

Merging #516 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage    93.8%   93.81%   +<.01%     
==========================================
  Files          65       66       +1     
  Lines        2762     2765       +3     
==========================================
+ Hits         2591     2594       +3     
  Misses        171      171
Flag Coverage Δ
#ios 93.81% <100%> (ø) ⬆️
#osx 93.81% <100%> (ø) ⬆️
#tvos 93.81% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...urces/Extensions/SwiftStdlib/ArrayExtensions.swift 100% <ø> (ø) ⬆️
...SwiftStdlib/RandomAccessCollectionExtensions.swift 100% <100%> (ø)
...tStdlib/RangeReplaceableCollectionExtensions.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb8203...b66c0e3. Read the comment docs.

@SwifterSwiftBot
Copy link

SwifterSwiftBot commented Jul 14, 2018

4 Messages
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖 Executed 487 tests, with 0 failures (0 unexpected) in 2.888 (3.306) seconds
📖 Executed 457 tests, with 0 failures (0 unexpected) in 1.980 (2.451) seconds
📖 Executed 331 tests, with 0 failures (0 unexpected) in 1.227 (1.577) seconds

Generated by 🚫 Danger

@SD10 SD10 requested a review from guykogus July 14, 2018 04:12
Copy link
Member

@omaralbeik omaralbeik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @LucianoPAlmeida 👍

@LucianoPAlmeida LucianoPAlmeida merged commit fdef062 into master Jul 14, 2018
@LucianoPAlmeida
Copy link
Member Author

Thank you guys 👍

@LucianoPAlmeida LucianoPAlmeida deleted the refactor-array-extensions branch July 14, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants