Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding internal files. #139

Closed
plasmLC opened this issue Sep 11, 2016 · 11 comments
Closed

Hiding internal files. #139

plasmLC opened this issue Sep 11, 2016 · 11 comments

Comments

@plasmLC
Copy link

plasmLC commented Sep 11, 2016

Guys, is this possible? My app provides advanced access to the /Dcouments application folder, and Realm, for example, allows to choose which file name should be used. SwiftyBeaver uses file names without leading dot, so it will be visible for app's users.

What do you suggest to hide your files from user's eyes?

@skreutzberger
Copy link
Collaborator

What files do you mean and for what destination?

@plasmLC
Copy link
Author

plasmLC commented Sep 12, 2016

/Documents/sbplatform_analytics.json
/Documents/sbplatform_entries_sending.json

As I said before, my app provides access to the /Documents folder directly to users, so it very unlikely to show these files.

@skreutzberger
Copy link
Collaborator

Ah ok, I understand what you mean. You want to change the values of the 3 files at https://github.com/SwiftyBeaver/SwiftyBeaver/blob/master/sources/SBPlatformDestination.swift#L71

I will put it on the list for the next release to make these variables public / open (for Swift 3). In the meantime you can manually get access to these variables by making the public in the framework codebase.

@plasmLC
Copy link
Author

plasmLC commented Feb 7, 2017

@skreutzberger sorry, but I could not manage it to work properly.

I'm doing this:
screen shot 2017-02-07 at 20 42 40

But one file - sbplatform_analitycs.json will be created in any case.
I suppose it will be there until behaviour of initialization will be changed: see from line 131 to line 147.

You're working with default names ANYWAY, so, please, do something with this. Either add leading dot before filenames or let user really change this urls and stop using default names before user changed it.

Guys, really need this fix — I could not allow my users see 'system' stuff among their documents.

@plasmLC
Copy link
Author

plasmLC commented Feb 21, 2017

@skreutzberger I suppose I need to fork the repo and do it on my own? Will you fix this?

@skreutzberger
Copy link
Collaborator

@plasmLC A solution could be to add the file names as additional parameters to init() but that may confuse users 🤔

@plasmLC
Copy link
Author

plasmLC commented Feb 21, 2017

@skreutzberger even if this init() will be convenience?

@skreutzberger
Copy link
Collaborator

let me do a PR and then you can see if you like it :)

@skreutzberger skreutzberger reopened this Feb 21, 2017
@skreutzberger
Copy link
Collaborator

@plasmLC please see here: #184 - would that solve your issue?

@plasmLC
Copy link
Author

plasmLC commented Feb 21, 2017

@skreutzberger yes, exactly what I need!

@skreutzberger
Copy link
Collaborator

@plasmLC Thanks! I will merge it into master and it will ship with the next version 1.1.3 later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants