Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Swift 1.2 #199

Closed
wants to merge 1 commit into from
Closed

Update to Swift 1.2 #199

wants to merge 1 commit into from

Conversation

kimdv
Copy link

@kimdv kimdv commented Apr 9, 2015

Updated and I can compile to Swift 1.2 Xcode 6.3

@kimdv
Update to Swift 1.2
ed1eb09 
Updated and I can compile to Swift 1.2 Xcode 6.3
@MarvinSchramm
Copy link

+1

8 similar comments
@wakinchan
Copy link

👍

@evenh
Copy link

evenh commented Apr 9, 2015

+1

@jlalvarez18
Copy link

👍

@minhoryang
Copy link

+1

@Kevsterstyle
Copy link

+1

@ccerinojr
Copy link

👍

@dwa012
Copy link

dwa012 commented Apr 9, 2015

+1

@jlalvarez18
Copy link

👍

@chrux
Copy link

chrux commented Apr 9, 2015

Awesome! but can we also update the tests? when running with carthage to build it, it's giving me

ios/Carthage/Checkouts/SwiftyJSON/Tests/RawRepresentableTests.swift:108:44: error: 'AnyObject' is not convertible to 'NSDictionary'; did you mean to use 'as!' to force downcast?
        XCTAssertTrue(dictionary == object as NSDictionary)
                                    ~~~~~~~^~~~~~~~~~~~~~~
                                           as!

@al7
Copy link

al7 commented Apr 10, 2015

+1

1 similar comment
@wangyhzzz
Copy link

+1

minhoryang
minhoryang reviewed Apr 10, 2015
View reviewed changes
Source/SwiftyJSON.swift
@@ -54,7 +54,7 @@ public enum Type :Int{
// MARK: - JSON Base

public struct JSON {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary? I don't think so.

@macu
Copy link

macu commented Apr 10, 2015

Please maintain the original whitespace so that meaningful changes stand out in diff.

@chrux
Copy link

chrux commented Apr 10, 2015

@macu +1

@parkej60
Copy link

+1

@adooylabs adooylabs mentioned this pull request Apr 11, 2015
Closed
@whusted
Copy link

whusted commented Apr 11, 2015

@mb89 Thanks for noting this

@LukeTangPL
Copy link
Member

Done db2b027

@LukeTangPL LukeTangPL closed this Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet