[WIP] swift test in Linux #708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix-swift-test * 'master' of https://github.com/SwiftyJSON/SwiftyJSON: Re-organize tests to satisfy SPM
|
@wongzigii Can you clarify what's left on this PR? Do you need an extra hand maybe? |
|
@ldiqual SPM currently doesn't provide a way to include resources e.g. Relate: https://lists.swift.org/pipermail/swift-users/Week-of-Mon-20161114/003987.html |
|
@wongzigii Given that it will remain unfixed for a while, maybe we should go ahead and put the json file in a gist that we'd download during the test? In theory it shouldn't be too hard to implement, it'd just make one test case a tad slow. What do you think? |
|
It makes sense at this time as a workaround. I will give it a try later. |
…o fix-swift-test * 'master' of https://github.com/SwiftyJSON/SwiftyJSON: update Integration section of README to reflect latest version in SPM usage subsection Fix duplicate comma typo update readme make casting nil to nsnull optional represent strings with nil as if it was nsnull Instead of checking for the Int8 type explicitly when setting 'object', cast the Int8 value to an Int and pass that into an NSNumber when setting 'int8' or 'int8Value' Update version in pod spec Add performance test Attemp to fix #697 Fix 'AnyObject' in comment and README.md The ‘isBool’ function on the NSNumber extension uses ‘trueObjCType’, which represents the type encoding for ‘true’ represented as an NSNumber, and ‘falseObjCType’, which represents the type encoding for ‘false’ represented as an NSNumber. Both type encodings are equal to ‘c’. However, an NSNumber that wraps around a value of type Int8 also has a type encoding of ‘c’. Therefore, a user who passes in a value of 0 or 1 (of type Int8) into JSON will expect to see the numbers 0 or 1 as the output because that was the intent. Unfortunately, that value will be wrapped into NSNumber and be considered a bool, so the user will see ‘true’ or ‘false’ instead. Fix typo in README.md Turn on render documentation mode. Finish subscript part. Add descriptions. Add getting a string using a path to the element. Updating subscript section in playground Added check for pre-escaped URLs to prevent double-escaping of % character # Conflicts: # Tests/SwiftyJSONTests/SequenceTypeTests.swift
|
Closing in favor of #943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixs #708
This PR aims at porting SwiftyJSON to Linux Platform.