Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podspec + make it work as a framework #99

Closed
wants to merge 1 commit into from
Closed

Add podspec + make it work as a framework #99

wants to merge 1 commit into from

Conversation

mblsha
Copy link

@mblsha mblsha commented Nov 22, 2014

I'm currently trying to migrate my project to CocoaPods using the basic framework described here: https://github.com/ashfurrow/Moya

@ValCapri
Copy link
Contributor

You should rebase your work on latest version of SwiftyJSON because your fork is "This branch is 2 commits ahead, 102 commits behind SwiftyJSON:master", maybe am I wrong. I am also trying CocoaPods 0.36.0.pre

@mblsha
Copy link
Author

mblsha commented Nov 23, 2014

Whoops, I'm making lots of silly mistakes when working late, sorry. Yep, writing podspecs for Swift libraries is surprisingly easy now with CocoaPods 0.36.0.pre.

@ValCapri
Copy link
Contributor

Pod::Spec.new do |s|
  s.name        = "SwiftyJSON"
  s.version     = "2.1.1"
  s.summary     = "SwiftyJSON makes it easy to deal with JSON data in Swift"
  s.homepage    = "https://github.com/SwiftyJSON/SwiftyJSON"
  s.license     = { :type => "MIT" }
  s.authors     = { "lingoer" => "lingoerer@gmail.com", "tangplin" => "tangplin@gmail.com" }

  s.osx.deployment_target = "10.9"
  s.ios.deployment_target = "7.0"
  s.source   = { :git => "https://github.com/SwiftyJSON/SwiftyJSON.git", :tag => "2.1.1" }
  s.source_files = "Source/*.swift"
end

Your podspec should be more like this. I think you forgot to run pod spec lint against CocoaPods 0.36.0.pre (You forgot the authors, .git at end of url, it is linked to your own fork not SwiftyJSON).

@LukeTangPL
Copy link
Member

@mblsha thanks. The pr is base on 1.0.0, but It is 2.1.1 now.
@ValCapri could you create a pull request?

@ValCapri
Copy link
Contributor

@tangplin : The PR is created. If you want, you could accept this PR and after mine. Like this every one would be "credited" for what they done.

@LukeTangPL
Copy link
Member

Merged in #100

@LukeTangPL LukeTangPL closed this Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants