New template tools to make better tests and replace test/deps system #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiip
force-pushed
the
test-templates
branch
3 times, most recently
from
7f0b664
to
eeacdf2
Compare
Swiip
force-pushed
the
test-templates
branch
from
eeacdf2
to
4b955ab
Compare
| lines: 0 | ||
| branches: 0 | ||
| functions: 0 | ||
| excludes: [] |
There was a problem hiding this comment.
Can you drop a link for documentation ?
There was a problem hiding this comment.
Had a hard time to find this back: https://github.com/gotwarlost/istanbul#configuring
Searching for this, I found examples of project which have only set the properties which are not defaults, it could be simpler...
|
A perfect example of "How to test a advanced Yeoman generator ?" Very nice jobs. All contributor should read these test suites. When you rebase with master we merge :-) ? |
|
Thanks, waiting for #279 to do the rebase only once |
Conflicts: app/templates/gulp/_build.js app/templates/gulp/_styles.js app/templates/gulp/_unit-tests.js test/deps/package.json test/test-files-generate.mocha.js
zckrs
pushed a commit
that referenced
this pull request
Feb 17, 2015
New template tools to make better tests and replace test/deps system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is 2 major evolutions.
First is template tools which ables to list, compile and store templates in a js form. It ables to test them isolated and having coverage on it. One of the result will be a drastic drop of coverage figures! There is a pretest command for compiling all templates because istanbul can't instrument files not present before the launch of the test.
The second point is the test dependencies. I moved all dependencies declaration in the package.js and bower.json. I removed all variables, most of them was in prompts.json. With this I can use my template tools to remove all ifs from the template and get simply enough dependencies files with all dependencies. This makes one and only place for all version management.