Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dep for task gulp scripts:watch #459

Merged
merged 1 commit into from
Apr 2, 2015
Merged

Add dep for task gulp scripts:watch #459

merged 1 commit into from
Apr 2, 2015

Conversation

zckrs
Copy link
Collaborator

@zckrs zckrs commented Mar 31, 2015

With Webpack (ES6) gulp watch use 'scripts:watch' and 'scripts'
These two tasks inject module preloader and loader to .tmp/serve/app/index.js

To fix #457 gulp should wait the end of 'scripts' before launch 'scripts:watch'

With Webpack (ES6) `gulp watch` use 'scripts:watch'  and 'scripts'
These two tasks inject module preloader and loader to `.tmp/serve/app/index.js`

To fix #457 gulp should wait the end of 'scripts' before launch 'scripts:watch'
@Swiip
Copy link
Owner

Swiip commented Apr 2, 2015

Made some tests, I still don't have a good understanding but I think you're right on the problem and I confirm your change fix it. So... go 👍

Swiip added a commit that referenced this pull request Apr 2, 2015
Add dep for task `gulp scripts:watch`
@Swiip Swiip merged commit 6686735 into Swiip:master Apr 2, 2015
@zckrs zckrs deleted the fix-gulp-scripts-es6 branch September 9, 2015 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected token }
2 participants