Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a vendor.cssPreprocessor in all cases #466

Merged
merged 4 commits into from
Apr 3, 2015

Conversation

Swiip
Copy link
Owner

@Swiip Swiip commented Apr 2, 2015

As said in #439, we should organize a vendor.cssPreprocessor regardless of the ui framework chosen. It's not because the main ui framework has not a version for your css preprocessor that you'll never have a dependencies which has one.

I also discovered that we injected css preproc deps in the index.cssPreprocessor and not in the vendor so I moved it which create a reason of existence for vendor.cssPreprocessor even when it's empty.

Finally I took the change for creating a sub folder structure in the src/app folder which was a mess.

fix #439

@Swiip Swiip force-pushed the always-use-vendor-css-prepro branch from 6b73505 to 75de994 Compare April 2, 2015 13:08
@zckrs
Copy link
Collaborator

zckrs commented Apr 2, 2015

// injector
// endinjector

should be stay in index.cssPrepro to manage the application's styles in a single file after a build.

For vendor.cssPrepro may be use Wiredep to inject all vendor's styles in a single file

@Swiip
Copy link
Owner Author

Swiip commented Apr 2, 2015

Should be better know.

  • index.cssPrepro is injected with the source files (which still has to be illustrated with a navbar.cssPrepro.
  • vendor.cssPrepro is injected with the bower deps though wiredep. It still depends of the quality of the bower.json of the deps, for example foundation doesn't link the scss version.

@zckrs
Copy link
Collaborator

zckrs commented Apr 3, 2015

👍 nice

zckrs pushed a commit that referenced this pull request Apr 3, 2015
Add a vendor.cssPreprocessor in all cases
@zckrs zckrs merged commit e60d31e into master Apr 3, 2015
@Swiip Swiip deleted the always-use-vendor-css-prepro branch September 9, 2015 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosing bootstrap generates vendor.scss in app, but using angular-material doesn't.
2 participants