Remove generated header file to make it a pure swift library #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bump minimum iOS deployment target to iOS 11
|
@maxim-chipeev Can I please get a review on this? Thanks. |
maxim-chipeev
approved these changes
Aug 17, 2023
|
@maxim-chipeev I don't have write access to merge, Can you please merge this and create a new release? Thanks 🙏 |
|
@maxim-chipeev Gentle bump on this 🙏 |
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel natively doesn't provide a rule to build mixed language (Swift + ObjC ) framework hence removing the .h inclusion from pod spec and also deleting the header file which Xcode creates when you create a framework target.
The Library was anyway all swift so deleting this header shouldn't create an issue.
This MR also bumps the iOS deployment target to iOS 11 to resolve podspec update issue with XCode 14.3