Make synchronous reads and writes to the container safe #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `services` parameter is not thread safe. Concurrent reads are safe, but concurrent reads with writes happening at the same time are not. This adds a read/write lock around it, making reads synchronous and safe, but writes block to ensure safety. Resolves Swinject#539
|
Seeing the same thing. Thanks for working on this. |
|
@mpdifran / @maxim-chipeev Any chance of a review on this? Thanks! 😄 |
|
@mpdifran / @maxim-chipeev Just bumping this again as we are still seeing it and we'd really rather not have to fork. |
maxim-chipeev
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
servicesparameter is not thread safe. Concurrent reads are safe, but concurrent reads with writes happening at the same time are not. This adds a read/write lock around it, making reads synchronous and safe, but writes block to ensure safety.Resolves #539