Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of tableView(willBeginEditingRowAt:), etc. #18

Closed
dricard opened this issue Mar 14, 2017 · 4 comments
Closed

Enable the use of tableView(willBeginEditingRowAt:), etc. #18

dricard opened this issue Mar 14, 2017 · 4 comments
Assignees
Milestone

Comments

@dricard
Copy link

dricard commented Mar 14, 2017

Make SwipeCellKit invoke the methods tableView(willBeginEditingRowAt:) and tableview(didEndEditingRowAt:).

@jerkoch
Copy link
Contributor

jerkoch commented Mar 14, 2017

Hey @dricard - Thanks for reminding me about this one. I'll take a look at it soon. I'm not sure if we should be calling existing table view delegate methods, or create similar ones on SwipeTableViewCellDelegate.

Opinions?

@dricard
Copy link
Author

dricard commented Mar 14, 2017

My first thought would be to call the existing tableview delegate methods but I don't know if that would break things with the SwipeTableViewDelegate. My main use for this is that I have running animations in some cells, and when the user starts a swipe I need to pause the animation (on willBeginEditingRowAt and resume on didEndEditingRowAt:.

@jerkoch jerkoch self-assigned this Mar 15, 2017
@jerkoch jerkoch added this to the 1.6.0 milestone Mar 16, 2017
jerkoch added a commit that referenced this issue Mar 17, 2017
…sue #18.

I may need to rename these delegate methods since UITableViewController uses its default implementation when not overrides.
@jerkoch
Copy link
Contributor

jerkoch commented Mar 18, 2017

Hey @dricard - I had to change the delegate method names to resolve an issue with UITableViewController.

I changed the willBeginEditingRowAt/didEndEditingRowAt delegate methods by adding an orientation parameter to differentiate them from the equivalent UITableView methods.

Please see the 95889a1 commit for a more detailed explanation.

@dricard
Copy link
Author

dricard commented Mar 21, 2017

@jerkoch I tested that and it works great in my context. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants