Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure with Xcode 10.2 beta #278

Closed
corteggo opened this issue Jan 29, 2019 · 2 comments
Closed

Build failure with Xcode 10.2 beta #278

corteggo opened this issue Jan 29, 2019 · 2 comments

Comments

@corteggo
Copy link

corteggo commented Jan 29, 2019 •
edited

SwipeCellKit has some build errors with Xcode 10.2 using Swift 4.2
@corteggo corteggo mentioned this issue Jan 29, 2019
Merged
@corteggo corteggo changed the title Build failures with Xcode 10.2 beta Build failure with Xcode 10.2 beta Jan 29, 2019
kurabi pushed a commit that referenced this issue Feb 7, 2019
@corteggo @kurabi
Xcode 10.2 (beta) compatibility (#279)
f24fe97 
* Fixed build errors occurring under Xcode 10.2 (Closes #278)
@kurabi
Copy link
Member

kurabi commented Feb 7, 2019

Fixed #279.

@kurabi kurabi closed this as completed Feb 7, 2019
@ItayAmzaleg
Copy link

ItayAmzaleg commented Mar 26, 2019 •
edited

Fixed #279.

What version is the fix?
I'm having build errors on Xcode 10.2 release version,
To be precise on SwipeController lines 76, 95 swipeable variable should be unwrapped.
Latest pod version 2.5.1 is from Dec 13 2018 any pod updates soon?

kurabi added a commit that referenced this issue Mar 26, 2019
@kurabi
Xcode 10.2 (#295)
e2dbc9a 
* Xcode 10.2 (beta) compatibility (#279)

* Fixed build errors occurring under Xcode 10.2 (Closes #278)

* Replace import Foundation with UIKit (#283)

Use UIKit as UIView.animate method is called, to allow compilation on latest Xcode 10.2 Beta (3)

* Switched sample app to show that a Swift 5 app can be compatible with SDK still being on Swift 4.2.
kurabi added a commit that referenced this issue Mar 26, 2019
@kurabi
Release 2.5.2 (#296)
c6b2e11 
* Update README.md

* Update README.md

* Update README.md

* Update README.md (#264)

* Fix swipeCells for UICollectionView (#266)

* Rev version up to 2.5.1 and update CHANGELOG.

* Fix crash when passing empty String to UIAccessibilityCustomAction (#270)

* Xcode 10.2 (#295)

* Xcode 10.2 (beta) compatibility (#279)

* Fixed build errors occurring under Xcode 10.2 (Closes #278)

* Replace import Foundation with UIKit (#283)

Use UIKit as UIView.animate method is called, to allow compilation on latest Xcode 10.2 Beta (3)

* Switched sample app to show that a Swift 5 app can be compatible with SDK still being on Swift 4.2.

* Rev version up.
Updated CHANGELOG.md

* Removed Xcode warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kurabi @ItayAmzaleg @corteggo