% Added protection against superview being nil and crashing #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This look good. |
kjpolaszek
added a commit
to HTD-Health/SwipeCellKit
that referenced
this pull request
Sep 10, 2017
* develop: Updated documentation link. Added Swift 4 Tag. Update twitter handle. Bumped Version. Update CHANGELOG.md Updated README.md to include notes about Swift 4. Fixes SwipeCellKit#48. This method was used to disable 3D touch previewing but this is now problematic to do in iOS 11 as this method inadvertently enables that iOS has disabled. Developers much now handling the disabling/enabling of 3D touch when cell is swiped with the aid of `SwipeTableViewCellDelegate`. Fix issue SwipeCellKit#51 where UIFeedbackGenerator crashes on non-haptic iOS devices only for 10.0.0 Fix issue SwipeCellKit#50 in relation to pixel misalignment on image & title of a swipe action. Bumped version. Update Docs Update CHANGELOG.md % Added protection against superview being nil and crashing (SwipeCellKit#46) Added highlighted background color for action button (SwipeCellKit#52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few crashes that look like:
Thread 0 Crashed: 0 SwipeCellKit 0x0000000100b32264 function signature specialization <Arg[1] = Dead> of SwipeCellKit.SwipeTableViewCell.point (inside : __C.CGPoint, with : __ObjC.UIEvent?) -> Swift.Bool (SwipeTableViewCell.swift:337) 1 SwipeCellKit 0x0000000100b2efe4 @objc SwipeCellKit.SwipeTableViewCell.point (inside : __C.CGPoint, with : __ObjC.UIEvent?) -> Swift.Bool (SwipeTableViewCell.swift:0) 2 UIKit 0x00000001955d3394 -[UIView(Geometry) hitTest:withEvent:] + 272 3 UIKit 0x0000000195770778 -[UITableViewCell hitTest:withEvent:] + 108Which points to "superview" being "dead". I have no idea how superview would be non-existent, but it is a good idea to avoid forced unwrapping, in my opinion.
This change guards against superview being nil.