Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drafter graph version instead of modified date #118

Open
Robsteranium opened this issue Feb 22, 2022 · 0 comments
Open

Use drafter graph version instead of modified date #118

Robsteranium opened this issue Feb 22, 2022 · 0 comments

Comments

@Robsteranium
Copy link
Member

Per @callum-oakley's comment on the graph-modified-time's PR:

We're using the modified times to determine if a graph has changed, but technically there's a race condition here if a graph changes twice within a millisecond (which appears to be likely to actually happen). The solution to this would be to use versions instead, which drafter now uses internally but which are not currently exposed by the public modified time graph. It would be a fairly small change to expose them and then update this work to make use of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant