-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export option exceptions #106
Export option exceptions #106
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 93.67% 93.41% -0.26%
==========================================
Files 20 20
Lines 996 1018 +22
==========================================
+ Hits 933 951 +18
- Misses 63 67 +4
Continue to review full report at Codecov.
|
I'm finished. Just thought of one more thing I wanted to test and added it while I was at it. |
what does read_secutrial currently do? In my opinion, it would give warnings that the labels, etc are not applied, but still import the data. this could be done by checking if something is in the export options and then setting the 3 logicals to false if the setup stuff is not there... |
Currently it will always try and add pat_id, centre and visit_name. This fails if the data for the procedure is missing. I also considered adding warnings in this PR but decided not to. I think that would be a work package related to #17. Once we have agreed on a set of suggested options (which will definitely include add-id, centre info and project setup) I suggest we tailor a verbose warning message for each option (if it differs from the suggestion) and point out what the effect is. |
maybe it makes sense to skip factorize, dates and labels if project setup isn't available and give a warning (an if loop in read_secutrial would do i think) |
I added a new directory with test exports to do this. NEWS.md explains what has been fixed. Basically, if the information to add the
pat_id
,visit_name
orcentre
columns is missing they are simply not added.One review should do but I will invite you both.
closes #67
closes #103
closes #105