Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace leftovers #146

Open
ciyer opened this issue Mar 13, 2024 · 0 comments
Open

Namespace leftovers #146

ciyer opened this issue Mar 13, 2024 · 0 comments

Comments

@ciyer
Copy link
Contributor

ciyer commented Mar 13, 2024

The namespace build concentrated on the core functionality, but there are some loose ends that should be tied up.

  • Folder rename The spec and and implementation for working with namespaces is in older components/renku_data_services/group/. This should be renamed to components/renku_data_services/namespace/
  • Pagination field unification In the query parameters the field is called per_page, but in the response it is per-page. We should pick one canonical name and use it everywhere (also impacts other V2 endpoints with pagination, like projects)
  • Find projects by namespace/slug Endpoints that operate on one project currently take the project ID to identify the project. They should be changed to alternatively accept the namespace and slug to identify the project.
  • Delete group also deletes any projects in that group Is this the desired behavior?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant