Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store next_url in the database during the OAuth2 authorization flow #210

Closed
leafty opened this issue May 17, 2024 · 0 comments · Fixed by #216
Closed

Store next_url in the database during the OAuth2 authorization flow #210

leafty opened this issue May 17, 2024 · 0 comments · Fixed by #216
Labels
cooldown Issues to be tackled during cooldown

Comments

@leafty
Copy link
Member

leafty commented May 17, 2024

GitHub wants an exact match between the configured redirect URL and the request parameter used during the authorization flow. This means that we should avoid sending a redirect URL which contains query parameters and instead store next_url in the database.

Example configured callback URL:

https://ci-renku-3620.dev.renku.ch/api/data/oauth2/callback?next_url=https%3A%2F%2Fci-renku-3620.dev.renku.ch%2Fv2%2Fconnected-services

Solving this may also make PKCE work (as we need to save the PKCE code as well). #193

@leafty leafty added the cooldown Issues to be tackled during cooldown label May 17, 2024
@leafty leafty closed this as completed in 3f69054 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cooldown Issues to be tackled during cooldown
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant