Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PKCE for connected services #193

Closed
olevski opened this issue May 10, 2024 · 0 comments · Fixed by #216
Closed

Add support for PKCE for connected services #193

olevski opened this issue May 10, 2024 · 0 comments · Fixed by #216
Labels
cooldown Issues to be tackled during cooldown

Comments

@olevski
Copy link
Member

olevski commented May 10, 2024

Currently PKCE is not supported but the authlib library we use should easily support PKCE.

This is the library docs page: https://docs.authlib.org/en/latest/index.html

And I think that the way to use PKCE is described here: https://docs.authlib.org/en/latest/client/oauth2.html#add-pkce-for-authorization-code
@leafty leafty added the cooldown Issues to be tackled during cooldown label May 17, 2024
This was referenced May 17, 2024
Closed
Merged
leafty added a commit that referenced this issue May 29, 2024
@leafty
feat: support PKCE and store next_url in the database (#216)
3f69054 
Fixes #193, fixes #210.

Add PKCE support and store `next_url` in the database.

* PKCE support is indicated by a new field, `use_pkce`, added to OAuth2 Clients. Note that only GitLab providers can support PKCE for now.
* Stores the `next_url` parameter in the database instead of passing it around as a query parameter. This allows final redirects to be customized for GitHub which does not allow extra query parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cooldown Issues to be tackled during cooldown
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support PKCE and store next_url in the database SwissDataScienceCenter/renku-data-services
2 participants
@leafty @olevski